Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 49.96% 50.04% +0.07%
==========================================
Files 15 15
Lines 3144 3153 +9
Branches 412 414 +2
==========================================
+ Hits 1571 1578 +7
- Misses 1425 1426 +1
- Partials 148 149 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates Solver.eigs() to expose additional scipy.sparse.linalg.eigsh() parameters aimed at reproducibility and flexibility, and adds tests around the new behavior (see #112).
Changes:
- Extend
Solver.eigs()withwhich,v0,mode, andrngparameters and always sort returned eigenpairs. - Add unit tests validating reproducibility via
rngand precedence of explicitv0. - Minor doc/docstring cleanups (numpydoc section underline, remove unused pandas intersphinx mapping).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
lapy/solver.py |
Exposes additional eigsh parameters, adds SciPy-version-dependent rng handling, and sorts eigenpairs for consistent output ordering. |
lapy/utils/tests/test_solver.py |
Adds tests for deterministic eigensolver outputs using rng and v0. |
lapy/utils/_imports.py |
Fixes numpydoc “Raises” underline formatting. |
doc/conf.py |
Removes the pandas intersphinx mapping (no remaining references found). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
See #112